Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevCenter DataPlane v2023-04-01 stable SDK from TypeSpec #35257

Merged
merged 40 commits into from
May 16, 2024

Conversation

drielenr
Copy link
Member

Description

We currently have a beta SDK targeting DevCenter 2023-04-01 API, and this PR is to have it released as a stable SDK - our first stable release, targeting same API.

Both SDKs (the last one released and this one) were generated from TypeSpec. The main change introduced was add model generation and updates on tests and samples to reflect that addition.

Arch board meeting occurred but APIView is not yet approved. Their requests have been addressed in this PR.

All SDK Contribution checklist:

  • [] The pull request does not introduce breaking changes
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Pipeline runs

Dry runs on the release pipeline:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5622&_a=summary

List of tests

DevBox

  • get_pool
  • list_pools
  • get_dev_box
  • get_remote_connection
  • get_action
  • list_actions
  • skip_action
  • delay_action
  • delay_all_actions
  • get_schedule
  • list_schedules
  • list_dev_boxes
  • list_all_dev_boxes
  • list_all_dev_boxes_by_user
  • begin_create_dev_box
  • begin_delete_dev_box
  • begin_start_dev_box
  • begin_stop_dev_box
  • begin_restart_dev_box

DevCenter

  • get_project
  • list_projects

Environments

  • begin_delete_environment
  • begin_create_or_update_environment
  • list_environment_types
  • list_catalogs
  • list_environments
  • list_all_environments
  • get_environment_definition
  • list_environment_definitions
  • list_environment_definitions_by_catalog
  • get_catalog
  • get_environment

Also updated samples.

@drielenr drielenr requested a review from lmazuel as a code owner April 17, 2024 22:26
@drielenr drielenr requested review from catalinaperalta, sebrenna, mccoyp and lmazuel and removed request for lmazuel April 17, 2024 22:26
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-developer-devcenter

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need async versions of all the samples. Same for tests, we need to have async tests. Also, please update samples to include the AZURE_TENANT_ID for authentication.

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're still missing async samples and tests, we need to have some async coverage before releasing the stable SDK.

@leti367
Copy link
Member

leti367 commented May 13, 2024

Looks like we're still missing async samples and tests, we need to have some async coverage before releasing the stable SDK.

Added the async tests and samples in the latest iteration.

Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, we just need to get CI passing and add a couple of fixes in the async samples

@catalinaperalta
Copy link
Member

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@catalinaperalta
Copy link
Member

/azp run python - devcenter - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend rebasing this PR with the latest main branch if possible. There were a number of recent changes to test sanitizing, which could affect playback tests once this is merged. I see that the test proxy version being used in the development branch is a month behind the latest, meaning that the bulk of changes aren't being used at the moment.

EDIT: Any test issues could alternatively be addressed after merging, since rebasing such a large PR would probably be very difficult -- I definitely wouldn't block this PR on it.

@leti367
Copy link
Member

leti367 commented May 14, 2024

I would recommend rebasing this PR with the latest main branch if possible. There were a number of recent changes to test sanitizing, which could affect playback tests once this is merged. I see that the test proxy version being used in the development branch is a month behind the latest, meaning that the bulk of changes aren't being used at the moment.

EDIT: Any test issues could alternatively be addressed after merging, since rebasing such a large PR would probably be very difficult -- I definitely wouldn't block this PR on it.

Got it! I will rebase it.

@leti367 leti367 force-pushed the drielene/dev-center-stable-sdk branch from 4fde303 to 00da9e5 Compare May 14, 2024 22:40
@mccoyp
Copy link
Member

mccoyp commented May 15, 2024

/azp run python - devcenter - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp
Copy link
Member

mccoyp commented May 16, 2024

/azp run python - devcenter - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@leti367
Copy link
Member

leti367 commented May 16, 2024

/azp run python - devcenter - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@catalinaperalta catalinaperalta merged commit d7c196f into main May 16, 2024
17 checks passed
@catalinaperalta catalinaperalta deleted the drielene/dev-center-stable-sdk branch May 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants