Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Anuj] boostrap script enhancements #693

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[Anuj] boostrap script enhancements #693

merged 1 commit into from
Apr 2, 2024

Conversation

promisinganuj
Copy link
Contributor

Type of PR

  • Documentation changes

Purpose

  • Reducing the number of parameters in environment file.
  • Updating the details in README.md.
  • General enhancements to bootstrap script.

Does this introduce a breaking change? If yes, details on what can break

  • No

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

N/A

Issues Closed or Referenced

@promisinganuj promisinganuj self-assigned this Mar 28, 2024
@promisinganuj promisinganuj linked an issue Mar 28, 2024 that may be closed by this pull request
Minor enhancements to boostrap script #692
Open
@promisinganuj promisinganuj changed the base branch from main to feat/fabric_cicd March 28, 2024 05:21
@promisinganuj promisinganuj mentioned this pull request Mar 28, 2024
Merged
3 tasks
sreedhar-guda
sreedhar-guda approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@sreedhar-guda sreedhar-guda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@promisinganuj promisinganuj merged commit a60bc5d into feat/fabric_cicd Apr 2, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreedhar-guda sreedhar-guda sreedhar-guda approved these changes

@ydaponte ydaponte Awaiting requested review from ydaponte

Assignees

@promisinganuj promisinganuj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor enhancements to boostrap script
2 participants
@promisinganuj @sreedhar-guda