Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public function to delete objects from ADF instance #30

Open
gidziu opened this issue Sep 6, 2020 · 4 comments
Open

Add public function to delete objects from ADF instance #30

gidziu opened this issue Sep 6, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@gidziu
Copy link

gidziu commented Sep 6, 2020

It looks like when an ADF object is excluded from deployment (via the Excludes property of the options) it is still considered to be "in source" and DeleteNotInSource does not apply to it.
For instance: if a given ADF object is already in the target ADF, and if a new deployment excludes that object from deployment and DeleteNotInSource flag is set to true, the excluded object will not be deleted from the target.
I would expect it to be deleted after the deployment.

@NowinskiK
Copy link
Member

Yes, this is exactly how the feature should work like.
'Excludes' property means you want to skip deployment of particular (set of) object(s), but definitely won't delete any of excluded objects. As latter property says "Delete Not in Source" - but the object is still in the source (repo) and should NOT be removed from ADF service.
I consider exposing the method to delete some objects explicitly if needed. Let me know if that would help in your scenario.

@NowinskiK NowinskiK added the wontfix This will not be worked on label Sep 6, 2020
@gidziu
Copy link
Author

gidziu commented Sep 7, 2020 via email

@NowinskiK
Copy link
Member

Thanks! Sounds good. I will do it as soon as I can.

@NowinskiK NowinskiK added enhancement New feature or request and removed wontfix This will not be worked on labels Sep 8, 2020
@NowinskiK NowinskiK self-assigned this Sep 8, 2020
@NowinskiK NowinskiK changed the title Excluded ADF objects not deleted after deployment Add public function to delete objects from ADF instance Sep 8, 2020
@NowinskiK NowinskiK added this to the Future version milestone Sep 17, 2020
@dsu4rez
Copy link

dsu4rez commented May 19, 2021

@NowinskiK @gidziu indeed, this feature will be really cool.
At the moment I'm migrating a project to a different Team Data Factory, and I thought about something related to this.
It would be great to have a "delete deployment" feature (all included adf objects in the deployment config files). Kind of a "reverse deployment" thing to be able clean ADF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants