Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No retries on REST API time-outs #295

Open
unboiled opened this issue Mar 29, 2023 · 0 comments
Open

No retries on REST API time-outs #295

unboiled opened this issue Mar 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@unboiled
Copy link

Describe the bug
Recently the ADF REST API seems to time-out frequently, causing the deployment to fail. While API time-outs are a Microsoft issue, I do think a retry on the API calls should be essential. For me this is happening multiple times a day now.

Since ADF is only a rather small part of the deployment, having to re-run the whole thing for multiple projects at a time can be quite daunting.

I do would understand if you'd see this as an enhancement rather than a bug though. Please let me know how you see this issue!

To Reproduce
N/A, intermittent issue with Microsoft

Expected behaviour
When an API time-out occurs, the script should re-attempt the API call a few times, up to a configurable amount. This prevents deployments to fail.

Screenshots
image

Version of PowerShell module of:

  • 0.101.000

Provide all files to reproduce the issue

2023-03-29T08:40:02.1628240Z Start deploying object: [pipeline].[pipeline_name] (2 dependency/ies)
2023-03-29T08:41:42.3155920Z New-AzResource : �[31;1mOperation failed because a request timed out.�[0m
2023-03-29T08:41:42.3158039Z �[31;1mAt /home/AzDevOps/.local/share/powershell/Modules/azure.datafactory.tools/0.101.0/private/Deploy-AdfObjectOnly.ps1:135 char:13�[0m
2023-03-29T08:41:42.3159873Z �[31;1m+             New-AzResource `�[0m
2023-03-29T08:41:42.3196750Z �[31;1m+             ~~~~~~~~~~~~~~~~�[0m
2023-03-29T08:41:42.3204598Z �[31;1m+ CategoryInfo          : CloseError: (:) [New-AzResource], Exception�[0m
2023-03-29T08:41:42.3205922Z �[31;1m+ FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceCmdlet�[0m
2023-03-29T08:41:42.4383179Z ##[error]Script failed with exit code: 1
@unboiled unboiled added the triage Issue is under investigation label Mar 29, 2023
@NowinskiK NowinskiK added enhancement New feature or request and removed triage Issue is under investigation labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants