New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback to alignChildren sort to ensure correct order #341
base: main
Are you sure you want to change the base?
Conversation
How does that solve the problem? |
To be honest I don't really know. I noticed that the Imagine a case there I tested with many different inputs and they all worked, so this shouldn't break anything. |
Looks like this has been fixed, I assume in this change, so I'll close this PR. |
No, this commit improves type support only. We can keep this open. |
@AykutSarac That other change has some logic changes too: |
Nevermind my other comment, it's still a bit broken so this PR is still needed. I'll check those merge conflicts tomorrow. |
@AykutSarac any updates? I've fixed the merge conflicts. |
Fixes #340