Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive collapsing of node trees #310

Closed
tram98 opened this issue Feb 14, 2023 · 7 comments
Closed

Adaptive collapsing of node trees #310

tram98 opened this issue Feb 14, 2023 · 7 comments
Labels
feature Feature request or suggestion 🙋🏻‍♂️help wanted Extra attention is needed todo If the issue or a feature request has "todo" label, it means it is intended to be added/fixed

Comments

@tram98
Copy link

tram98 commented Feb 14, 2023

Feature

A good addition could be to re-render the node tree when a node is collapsed or expanded. This would reduce the spread of different nodes around those less important to the user.
Making the nodes draggable could be a different approach, but I might be getting ahead.

Thank you very much for the tool!!!

Cheers,
Jannick

Alternative solutions or implementations

No response

Other context

No response

@tram98 tram98 added the feature Feature request or suggestion label Feb 14, 2023
@AykutSarac
Copy link
Owner

This would be really great, to trigger this the nodes and edges data should be updated. This behaviour will trigger a render on whole canvas and cause lagging while painting large data. To avoid this current behaviour is to hide/display through CSS. We can take suggestions for this in this issue.

@AykutSarac AykutSarac added the 🙋🏻‍♂️help wanted Extra attention is needed label Feb 14, 2023
@tram98
Copy link
Author

tram98 commented Feb 14, 2023

I have no expertise in Webdev, so i fear that my capabilities to support here will be limited.

@AykutSarac AykutSarac added the todo If the issue or a feature request has "todo" label, it means it is intended to be added/fixed label Mar 8, 2023
@faizanu94
Copy link

Hi @tram98, it would be expensive to trigger a re-render when expanding or collapsing nodes, especially for large trees. However, could you please provide more information about the use case of adaptive collapsing of node trees with an example as to understand the desired behaviour in detail? Thanks

@tram98
Copy link
Author

tram98 commented Apr 1, 2023

Hey there,

the basic idea would as follows: Suppose you have a big tree with 3 big nodes that take up a lot of space.
When I collapse the node in the middle, there is a big empty space between the top and bottom nodes. Therefore, i would suggest repainting the elements on the same level when an element is (un)collapsed.

Is that explanation clear enough?

@hammadahamed
Copy link

Hey there !
Dragging would be pretty nice and doable for now, Although selective re-rendering is a 'no-idea-on-that-yet' for me.
Would like to contribute on this.
Its marked unassigned, shall i take this up ? @AykutSarac

@AykutSarac
Copy link
Owner

AykutSarac commented Sep 26, 2023

Initially when collapsing implemented it was re-rendering the entire graph. For big graphs, this is very inefficient.

@AykutSarac
Copy link
Owner

I've opened a new issue for follow-up with details.
#356

@AykutSarac AykutSarac closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or suggestion 🙋🏻‍♂️help wanted Extra attention is needed todo If the issue or a feature request has "todo" label, it means it is intended to be added/fixed
Projects
None yet
Development

No branches or pull requests

4 participants