Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room members information (e.g. displayname) should not be fetched for non-local users #336

Open
waclaw66 opened this issue Feb 10, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@waclaw66
Copy link

It's not shown when some of members originate from different homeserver (matrix.org).

obrazek

However Displayname field of local users is shown with correct value for a small moment and then all displaynames are changed to that red icon.

Expected result is that only members from other homeservers shall have that red icon because of response 400

{"errcode":"M_UNKNOWN","error":"Can only look up local users"}
@awesome-manuel awesome-manuel added the invalid This doesn't seem right label Feb 7, 2024
@awesome-manuel
Copy link
Member

Works for me. Can you provide more logs from the browser console?

@waclaw66
Copy link
Author

waclaw66 commented Feb 7, 2024

obrazek
obrazek

Displaynames from local server are properly fetched, unlike federation users. Local server doesn't provide information about federation users at endpoint https://server/_synapse/admin/v2/users/.
Synapse-admin shouldn't request federation users info on local homeserver, please check endpoints within
https://github.com/element-hq/synapse/blob/develop/synapse/rest/admin/users.py

@awesome-manuel
Copy link
Member

That is expected, yes.

What I don't see in my setup is:

However Displayname field of local users is shown with correct value for a small moment and then all displaynames are changed to that red icon.

@awesome-manuel awesome-manuel changed the title Room members Displayname is not shown correctly Room members information (e.g. displayname) should not be fetched for non-local users Feb 8, 2024
@awesome-manuel awesome-manuel added bug Something isn't working and removed invalid This doesn't seem right labels Feb 8, 2024
@waclaw66
Copy link
Author

waclaw66 commented Feb 8, 2024

That is expected, yes.

What I don't see in my setup is:

However Displayname field of local users is shown with correct value for a small moment and then all displaynames are changed to that red icon.

Try to enable "Stop on exception", then first name of local user is visible. After excecution is complete, red icon is everywhere. I would expect, that local users have their displaynames, federated have red icon. It happens in the room with 5 local users and 1 federated.

obrazek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants