Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy of selectable filters between rooms and rooms_directory #251

Open
tgurr opened this issue Feb 21, 2022 · 2 comments
Open

Discrepancy of selectable filters between rooms and rooms_directory #251

tgurr opened this issue Feb 21, 2022 · 2 comments
Labels
enhancement New feature or request wait for admin API This needs some changes in synapse

Comments

@tgurr
Copy link
Contributor

tgurr commented Feb 21, 2022

rooms and rooms_directory have different selectable filters, while it would be handy to filter for e.g. theme/thema and probably others on rooms as well since rooms_directory only gives a partly list to filter on.
filter02
filter01

@dklimpel
Copy link
Contributor

The reason is, that this are different APIs with different return values.
The room directory is the public API: https://spec.matrix.org/v1.2/client-server-api/#get_matrixclientv3publicrooms
And the room list is an admin API: https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#list-room-api

The server admin gets mor information than a normal user.

@tgurr
Copy link
Contributor Author

tgurr commented Feb 21, 2022

The reason is, that this are different APIs with different return values. The room directory is the public API: https://spec.matrix.org/v1.2/client-server-api/#get_matrixclientv3publicrooms And the room list is an admin API: https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#list-room-api

The server admin gets mor information than a normal user.

Thanks, that explains why it's not possible to replicate 1:1 between the two, but room_id, topic and canonical_alias filters from rooms_directory could still be added to rooms right? Might change the issue topic for the request to rather "add missing selectable filters present in rooms_directory to rooms" then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wait for admin API This needs some changes in synapse
Projects
None yet
Development

No branches or pull requests

3 participants