Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a font bug need fix or notice #138

Open
L1uTongwei opened this issue Aug 4, 2022 · 7 comments
Open

a font bug need fix or notice #138

L1uTongwei opened this issue Aug 4, 2022 · 7 comments

Comments

@L1uTongwei
Copy link

L1uTongwei commented Aug 4, 2022

In font files, i found this:

//[
0b11000000,
0b10000000,
0b10000000,
0b10000000,
0b11000000,
0b00000000,
0,				//for the life of me I have no idea why this is needed....
//\
0b10000000,
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,

If you use //\, it will let the comment extend to the next line, so it is useless for the line of 0b10000000,.

So in fact the charcacter '\' is:

0
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,

It's a bug.

@L1uTongwei
Copy link
Author

In file font4x6.cpp.

@L1uTongwei
Copy link
Author

I fixed it with

//[
0b11000000,
0b10000000,
0b10000000,
0b10000000,
0b11000000,
0b00000000,
//(backslash)
0b10000000,
0b10000000,
0b01000000,
0b00100000,
0b00100000,
0b00000000,

@L1uTongwei
Copy link
Author

@Avamander

@L1uTongwei
Copy link
Author

Well, if you open -Wall & -Wextra, you'll get:

thirdparty/TVout/TVoutfonts/font4x6.cpp:426:1: warning: multi-line comment [-Wcomment]
 //\
 ^

@orangefabri
Copy link

I remember I found same bug on the code.

did you made font the size is not the multiple of 8?

I wanted to make 11x11 font but it was very difficult.

8 or 16 font was easy to made

@L1uTongwei
Copy link
Author

I remember I found same bug on the code.

did you made font the size is not the multiple of 8?

I wanted to make 11x11 font but it was very difficult.

8 or 16 font was easy to made

Well, if the size is not the multple of 8, it will be very diffcult to make font allign on the screen.

And the code are running base on the multiple of 8. The wide of the screen is multiple of 8.

So That's diffcult. I just want to notice everyone there's a clearly bug on the font.

@L1uTongwei
Copy link
Author

@orangefabri If you are interested in the code, why not join the develop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants