Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes made in email editor are not reflected in the preview or in sent emails #7459

Open
donnapep opened this issue Jan 30, 2024 · 3 comments · May be fixed by #7595
Open

Style changes made in email editor are not reflected in the preview or in sent emails #7459

donnapep opened this issue Jan 30, 2024 · 3 comments · May be fixed by #7595
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Emails [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jan 30, 2024

Steps to Reproduce

  1. Go to Sensei LMS > Settings > Emails.
  2. Enable the Course Completed email and then edit it.
  3. Change the styles in some way (e.g. change the button colors and center align it).
  4. Save and preview.
  5. Complete a course as a student.

What I Expected

The styling changes to be reflected in both the preview and in the sent email.

What Happened Instead

The button has no background color and isn't center-aligned.

Note that the scope of this bug is larger than just the buttons. None of the style changes that are made in the editor are applied in the actual email.

Some of these changes aren't applied in the editor either. For example, changing the background and text color of dynamic text works in the editor (e.g. [course:name]), but only the background color works for static text.

We need to check every element in our emails (i.e. title, content and buttons) to ensure block styles (color, typography*, dimensions etc.) work for all of them.

*We don't need to make relative units work as per #6566.

Screenshot / Video

Editor

Screenshot 2024-01-30 at 12 07 42 PM

Preview

Screenshot 2024-01-30 at 12 08 05 PM

Email

Screenshot 2024-01-30 at 12 08 40 PM

@donnapep donnapep added [Type] Bug [Pri] High Ship ASAP Emails [Status] Triaged Issue has been triaged [Pri] Normal Can wait for the next release and removed [Pri] High Ship ASAP labels Jan 30, 2024
@donnapep
Copy link
Collaborator Author

Related #6691?

@donnapep donnapep added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 20, 2024
@donnapep
Copy link
Collaborator Author

6220055-zen

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 6220055-zen

@merkushin merkushin self-assigned this Apr 19, 2024
@merkushin merkushin linked a pull request Apr 22, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Emails [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants