Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly message is not displayed anymore when activating WCPC + Sensei LMS #7472

Open
renatho opened this issue Feb 6, 2024 · 1 comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Cosmetic issue, low impact, easy workaround [Type] Bug

Comments

@renatho
Copy link
Contributor

renatho commented Feb 6, 2024

It seems to be a core issue, so I opened a ticket here where you can see more details, but I'm also opening this issue just to keep track of the problem, since it impacts Sensei.

Steps to Reproduce

  1. Install and activate WooCommerce and WCPC.
  2. Install and activate Sensei LMS.

What I Expected

To see a friendly error that both plugins shouldn't be activated at the same time. More details.

Screenshot 2024-02-06 at 18 23 21

What Happened Instead

A simple fatal error without any explanation.

Screenshot 2024-02-06 at 18 23 27

Alternative Solution

If we don't want to wait for a solution in the core, a simple alternative could be a message a little more aggressive with wp_die instead of die. I say that it's a little more aggressive because it would display a message in the whole screen instead of a message in the top of the page.

Another alternative that would demand a little more work but would have a better experience is the same way that we check compatibility issues on Sensei Pro.

PHP / WordPress / Sensei LMS version

PHP 8 / WordPress 6.4 / Sensei LMS 4.20.2

Browser / OS version

Chrome / Mac OSX

Context / Source

p1707237469398059-slack-C02P7FHLVR9
7615559-zd-a8c

@renatho renatho added [Type] Bug [Pri] Low Cosmetic issue, low impact, easy workaround labels Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 7615559-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Cosmetic issue, low impact, easy workaround [Type] Bug
Projects
None yet
Development

No branches or pull requests

1 participant