Invoke-LabCommand -PostInstallationActivity -AsJob not creating a background job #1303
Comments
|
Hi @Trentent, we wait for custom roles, as they can consist of more than one script that is being executed. Normal PostInstall and PreInstall activities are jobs which can be returned using the Changing will take time as it would require a lot more orchestration to work for all possible scenarios |
|
I've written a little piece of code that can partially do this functionality (for the purposes I need, this works perfectly). I'm using the install-lab command to create the resources I require, which will power on and configure the domain controller machine. Machines with custom roles (aka, PostInstallationActivities) are not managed with the install-lab command when used with the install-lab command I have specified. With that, I can take control of the power on and install of post installation activities. Install-Lab -BaseImages -NetworkSwitches -VMs -Domains -NoValidation -verbose
Write-ScreenInfo "Getting list of machines yet to be booted"
$machineStatus = Get-LabVMStatus
$vms = New-Object System.Collections.Generic.List[string]
foreach ($machineToStart in $machineStatus.Keys) {if (($machineStatus[$machineToStart]) -eq "Stopped") { $vms.add("$machineToStart")}} ## Get list of machines yet to be started
Write-ScreenInfo "Starting $($vms.count) virtual machine(s)"
Start-VM -Name $vms
Write-ScreenInfo "Waiting for AutomatedLab to be able to contact virtual machines..."
Wait-LabVM -ComputerName $vms ## wait for all machines to finish booting
Write-ScreenInfo "Starting Postinstallation installs"
$PostInstallActivityMachines = Get-LabMachineDefinition | Where {$_.PostInstallationactivity.count -ge 1}
$RunSpaceJobs = New-Object System.Collections.Generic.List[PsObject]
## Need to get a list of post-install tasks and create a runspace to start each process with a process wait so that an order of install can be completed.
foreach ($postInstallMachine in $PostInstallActivityMachines) {
$postInstallJobs = New-Object System.Collections.Generic.List[PsObject]
if (Get-Variable $postInstallMachine.Name -ErrorAction SilentlyContinue) { Remove-Variable $postInstallMachine.Name -ErrorAction SilentlyContinue }
New-Variable -Name $postInstallMachine.Name -Value $(New-RunspacePool -ThrottleLimit 1000)
foreach ($postInstallActivity in $postInstallMachine.PostInstallationActivity) {
$Script = "$(($postInstallActivity).DependencyFolder.Value)\HostStart.ps1"
$Parameters = ($postInstallActivity).SerializedProperties | ConvertFrom-PSFClixml
Write-ScreenInfo "Start-Process -FilePath powershell.exe -ArgumentList `"-ExecutionPolicy Unrestricted -File $Script $(&{$args}@Parameters)`" -PassThru -Wait"
$postInstallJobs.Add("Start-Process -FilePath powershell.exe -ArgumentList `"-ExecutionPolicy Unrestricted -File $Script $(&{$args}@Parameters)`" -PassThru -Wait`n") ##new line backtick required or else the scriptblock will be interpreted as a single line.
Start-Sleep -Seconds 2 #just to give powershell processes a second or two to start
#$PostInstallJobs.add($postInstallJob)
}
Write-Output "Starting Runspace Job: $($postInstallMachine.Name)"
Write-Host "ScriptBlock: `n Number of Lines: $($postInstallJobs.count)" -ForegroundColor Green
Write-Host "$($postInstallJobs | Out-String)" -ForegroundColor Green
$RunSpaceJobs.Add($(Start-RunSpaceJob -ScriptBlock ([scriptblock]::create($postInstallJobs)) -RunspacePool $((Get-Variable -Name $postInstallMachine.Name).Value )))
}This code will power on all VM's after the domain is stood up. It will then wait for all machines to be online and available. Once that occurs, it will generate a "script" based on the post installation activities "HostStart.ps1" command and execute each in order, asynchronously, per-machine. This code does not take into account HostEnd or local execution of Post Installation Activities (at this time). |
I've created custom Citrix roles to be installed on a series of VM's. These need to be installed in a sequence which AutomatedLab seems to do via the order the custom roles are added to the LabMachineDefinition. But they have no other dependency so executing them in parallel across multiple machines would save lots of time.
In order to execute in parallel I'm using the following command:
$PostInstalljobs = Invoke-LabCommand -PostInstallationActivity -ActivityName 'Post-installation' -ComputerName $postInstallMachines -AsJobThis is not creating a job per-machine and executing in the background, it is executing sequentially starting for the first machine and first role, waiting for that first role execution to finish, then executing the next role.. Once all roles are complete for the first machine it moves onto the next machine.
Expected behavior
Each machine should have a job created to be executed in the background and the roles installed in order
Actual behavior
AsJob appears to be ignored and each machine is operated on one at a time.
Steps to reproduce
Create custom roles that take a while (eg, HostStart.ps1 with a Start-Sleep 600)
Add Custom Role to multiple LabMachineDefinition
Create Machines in Lab:
Attempt to execute post installation activities manually:
Environment details
PowerShell Version
AutomatedLab components
The text was updated successfully, but these errors were encountered: