Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean export environment variables #298

Open
prasadtalasila opened this issue Apr 13, 2018 · 1 comment
Open

Clean export environment variables #298

prasadtalasila opened this issue Apr 13, 2018 · 1 comment

Comments

@prasadtalasila
Copy link
Member

Description

We need clean export of environment variables to node.js processes. The need arose because of the following hiccup:

During functional tests, it was observed that nyc can't wait for a long time (>60 seconds) to collect the coverage data. Hence, we needed to go for incremental code coverage report generation. Such a step requires that we start and stop the AutolabJS components for each functional test. Since we perform bash shell export of environment variables, we end up with lot of unnecessary exported variables over a sequence of tests. We need a guarantee of clean environment for each of the node.js processes.

One way to achieve the clean environment is to use dotenv node.js package to provide the environment variables. The environment variables are to be kept in deploy/configs/env directory.

Steps to Reproduce

  1. code coverage reporting of functional tests

Expected behavior: [What you expect to happen]
Code coverage reporting works

Actual behavior: [What actually happens]
Code coverage report does not report properly for functional tests.

Reproduces how often: [What percentage of the time does it reproduce?]
Every time functional tests are run.

@prasadtalasila prasadtalasila added this to TODO in Critical issues via automation Apr 13, 2018
@prasadtalasila
Copy link
Member Author

Use rc module for reading the configs in all the AutolabJS components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant