Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User blocked on main server - timeouts for requests #124

Open
prasadtalasila opened this issue Apr 6, 2017 · 2 comments
Open

User blocked on main server - timeouts for requests #124

prasadtalasila opened this issue Apr 6, 2017 · 2 comments

Comments

@prasadtalasila
Copy link
Member

A user submitting an evaluation request gets blocked indefinitely under the following circumstances

  1. User has a GitLab account
  2. User submits the file (a.out) in this case but the file is not in the correct language directory. Infact, no language directory exists in the student's repo lab0. The repo has the following structure:

lab0
|-- a.out

  1. Student submits the evaluation request

The main server now waits indefinitely for a response - however, the execution node doesn't crash.

Also, I tried to submit the evaluation request from a different device and it still blocks the user. I think instead of blocking the socket, the user is blocked in the implementation.

(Thanks to @rajat503 for bringing attention to this bug and for providing detailed bug report.

@prasadtalasila
Copy link
Member Author

The problem is solved using timeouts for each of the pending requests.

@prasadtalasila
Copy link
Member Author

Use a timeout of 3M for timing out for expiring all evaluation requests going from one autolab component to another. The autolab components that send evaluation requests are: browser-code, mainserver, and loadbalancer.

Timeouts technique avoid deadlocks in the system.

@prasadtalasila prasadtalasila changed the title User blocked on main server User blocked on main server - timeouts for requests Aug 20, 2017
@prasadtalasila prasadtalasila removed this from TODO in Critical issues Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant