Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoiser capabilities? Error on missing Denoiser.cpp/h #33

Open
DanEnglesson opened this issue Apr 8, 2024 · 2 comments
Open

Denoiser capabilities? Error on missing Denoiser.cpp/h #33

DanEnglesson opened this issue Apr 8, 2024 · 2 comments

Comments

@DanEnglesson
Copy link

Hi,

Are there plans to add in denoise capabilities to this opensource repository? It looks like Aurora has that ability according to this video?

https://www.youtube.com/watch?v=8tDJn8ms-y8

And there are breadcrumbs to enable it in but getting stomped on the missing Denoiser.cpp and Denoiser.h files.

# Excluding NRD and NRI for Aurora 22.11 since denoiser

"Source/DirectX/Denoiser.cpp"

It would have been awesome to get this with denoising capabilities as it is a great interactive renderer and are curious to hear your thoughts on adding to this repository or if it is up to each consumer to add it separately.

Best Regards,
Dan

@pixnblox
Copy link
Contributor

pixnblox commented Apr 8, 2024

We have denoising support internally based on NVIDIA NRD:

https://github.com/NVIDIAGameWorks/RayTracingDenoiser

You can see that operating in Autodesk Inventor. However, it relies on a version of NRD that predates their open source release, so we were not allowed to share that. We plan to update our integration to a more recent version that is open source. We could also host different denoisers if you have a different denoiser in mind.

@DanEnglesson
Copy link
Author

Thanks for the quick response. That explains why the denoiser files were left out in the open-source repository.
I think the NRD denoiser is the preferred one but being able to have multiple denoiser such as Intel's denoiser would be of interest too.

Good the hear that you are planning to integrate a more recent version of NRD that is open source. I just wanted to see if there was a plan to release an update to this or if it is something that the community could help develop.

Cheers,
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants