Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albedo project - governance model change #821

Closed
zvirja opened this issue Sep 1, 2017 · 8 comments
Closed

Albedo project - governance model change #821

zvirja opened this issue Sep 1, 2017 · 8 comments
Labels

Comments

@zvirja
Copy link
Member

zvirja commented Sep 1, 2017

The AutoFixture.Idioms project depends on Albedo that is being currently maintained by @ploeh. Currently we are migrating our projects to support .NET Standard and it appeared that Albedo doesn't support that world. I've created a PR to Albedo project to solve that, however Mark rejected it saying that he is no longer interested in that area, so he doesn't want to spend his time on that. Instead Mark suggested to transfer project to the AutoFixture account as apparently we are the only major consumer of that lib.

Given that this is the only way to proceed with .NET Standard support for Idioms, I suggest the following plan:

From @AutoFixture/core side:

  1. We create one more repository under the AutoFixture account.
  2. We create a copy of project (simply push all the commits).
  3. We enable .NET Standard support for the lib and publish v2.0 to NuGet.

From @ploeh side:

  1. Push the sign key to the master branch as we'll open it in any case.
  2. Add AutoFixture, AlexPovar and klimisa as package owners (to be same as here).
  3. Later change the Readme to mention that project has been transferred to another place.

Notice the following:

  1. @ploeh To indicate the changed ownership we will remove the Ploeh namespace prefix from code. That is to align project with a decision made in Discussion: The 'Ploeh' namespace prefix #745.
  2. @ploeh We'll add AutoFixture as a co-author of the package. We'll keep the current copyrights as we haven't agreed yet what to do with them.
  3. @moodmosaic @adamchester @klimisa I'm ready to do this only if you allow me to migrate project, add .NET Standard 2.0 support and rework the build approach without a need to create PRs. No business logic will be affected by that (if it is - I'll create a PR to discuss). I'll need to significantly reorganize the project (to align it with AutoFixture one) and it will be painful to do that via PRs.

@ploeh @AutoFixture/core Do you agree with such a plan? 😉

@zvirja zvirja added the question label Sep 1, 2017
@moodmosaic
Copy link
Member

moodmosaic commented Sep 1, 2017

Albedo―while being one of the best object-oriented C# codebases I'm aware of, a useful, and interesting open-source project―has no place in the AutoFixture organization, IMHO.

That was one of the primary reasons we actually developed it under @ploeh's GitHub account. I see no reason going back on this decision.

There is a ton of PRs going on already, with a high frequency of changes like never before and just a few available reviewers.


  • I'd suggest to hold off the decision until most of the v4 milestone issues are closed
  • In case you decide to move forward on this, do not add me as a reviewer on the pull requests. I currently don't have more bandwidth for reviews

@zvirja
Copy link
Member Author

zvirja commented Sep 1, 2017

@moodmosaic Thanks for your reply! A bit unexpected decision, but I completely understand it! Ok, let's live without .NET Core support for Idioms for now and decide what to do at the end of v4.

@zvirja
Copy link
Member Author

zvirja commented Sep 14, 2017

I decided to follow a bit different approach - I created a standalone organization for that project: https://github.com/AlbedoOrg. We'll transfer the project there and I'll add the .NET Standard support. I'll do that myself by applying the similar layout as we have here. Later other guys like @moodmosaic @ecampidoglio could also participate if they wish.

Currently I'm waiting for the @ploeh actions to proceed further.

@zvirja
Copy link
Member Author

zvirja commented Sep 21, 2017

We already transferred the repo, so this question should be closed. I'll add @adamchester and @moodmosaic as co-owners, as they contributed to the library in past.

@zvirja zvirja closed this as completed Sep 21, 2017
@moodmosaic
Copy link
Member

You should also add @jwChung. He did a lot of great work in Albedo.

@zvirja
Copy link
Member Author

zvirja commented Sep 23, 2017

Sure, no concerns from my side. Please add him - you also have admin rights 😊

@jwChung
Copy link
Contributor

jwChung commented Sep 24, 2017

@moodmosaic Long time no see. Thank you for your kind attention. @zvirja

@moodmosaic
Copy link
Member

@jwChung, you are welcome! I've just invited you a few hours ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants