Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in when SOcrs, SOextent are set #109

Open
raymondben opened this issue Feb 2, 2023 · 0 comments
Open

Inconsistency in when SOcrs, SOextent are set #109

raymondben opened this issue Feb 2, 2023 · 0 comments
Assignees

Comments

@raymondben
Copy link
Member

raymondben commented Feb 2, 2023

WIth automap, the SOcrs and SOextent are set when the map is constructed:
https://github.com/AustralianAntarcticDivision/SOmap/blob/dev-0.7/R/new_automap.R#L243

SOcrs is set again when the automap is plotted:
https://github.com/AustralianAntarcticDivision/SOmap/blob/dev-0.7/R/SOmap_auto.R#L376
(but SOextent is not)

But with SOmap these aren't set until the map is actually plotted:
https://github.com/AustralianAntarcticDivision/SOmap/blob/dev-0.7/R/SOmap.R#L170

I think automap_maker should not be setting SOcrs or SOextent, that should happen at plot time ?? (https://github.com/AustralianAntarcticDivision/SOmap/blob/dev-0.7/R/SOmap_auto.R#L376)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants