Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .editorconfig. #457

Open
0xWDG opened this issue Sep 11, 2023 · 1 comment
Open

Support .editorconfig. #457

0xWDG opened this issue Sep 11, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest #Hacktoberfest
Milestone

Comments

@0xWDG
Copy link
Member

0xWDG commented Sep 11, 2023

Is your feature request related to a problem? Please describe.

Nope

Describe the solution you'd like

Native support for .editorconfig files.
https://editorconfig.org/

Describe alternatives you've considered

None

Additional context

None

@0xWDG 0xWDG added the enhancement New feature or request label Sep 11, 2023
@0xWDG 0xWDG added this to the Version 1.0 milestone Sep 11, 2023
@0xWDG
Copy link
Member Author

0xWDG commented Sep 11, 2023

Sample .editorconfig file.

# top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf
insert_final_newline = true

# Matches multiple files with brace expansion notation
# Set default charset
[*.{js,py}]
charset = utf-8

# 4 space indentation
[*.py]
indent_style = space
indent_size = 4

# Tab indentation (no size specified)
[Makefile]
indent_style = tab

# Indentation override for all JS under lib directory
[lib/**.js]
indent_style = space
indent_size = 2

# Matches the exact files either package.json or .travis.yml
[{package.json,.travis.yml}]
indent_style = space
indent_size = 2

0xWDG added a commit that referenced this issue Sep 14, 2023
# Description

<!--- REQUIRED: Describe what changed in detail -->
Add ini parser, made some tests

# Our first test!
<img width="492" alt="Screenshot 2023-09-12 at 21 19 07"
src="https://github.com/AuroraEditor/AuroraEditor/assets/1290461/e9d9d46b-6186-486b-96df-f37d3c76f23d">


# Related Issue

<!--- REQUIRED: Tag all related issues (e.g. * #23) -->
* #457 (made the ini parser (`.editorconfig` file is basically an ini)

# Checklist

<!--- Add things that are not yet implemented above -->
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] I documented my code (where needed)
- [ ] I added localization
- [x] I added tests (and they pass)

# Screenshots

<!--- REQUIRED: if issue is UI related -->

![F89D898B-D7F0-4DAD-845E-2DF35B670294_4_5005_c](https://github.com/AuroraEditor/AuroraEditor/assets/1290461/7de7ee3e-8feb-45ae-b819-766af11669ce)
<!--- IMPORTANT: Fill out all required fields. Otherwise we might close
this PR temporarily -->
@0xWDG 0xWDG added good first issue Good for newcomers hacktoberfest #Hacktoberfest labels Sep 15, 2023
aurora-care-bear pushed a commit that referenced this issue Feb 10, 2024
## Summary

Support for `.editorconfig`

## Changes Made

- Created "sample" `.editorconfig`
- Parser for INI files (Done in
#458)

## TODO

- Support ** (Matches any string of characters)
- Support ? (Matches any single character)
- Support {num1..num9} (Matches from 0...9)

## Motivation

To become fully supported with `.editorcondig`, see #457

## Testing

- None yet.

## Screenshots/GIFs

N/A

## Checklist

Please ensure all of the following are completed before submitting the
PR:

- [x] Code has been tested and verified.
- [x] Documentation has been updated to reflect the changes.
- [x] All tests pass successfully.
- [x] Code follows the project's coding guidelines and style.
- [x] The branch is up-to-date with the latest changes from the main
branch.
- [x] Reviewed by at least one other contributor.

## Related Issues

This PR addresses the following issue(s): #457 

## Additional Notes

None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest #Hacktoberfest
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant