Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences terminal theme #350

Open
Maartz opened this issue Dec 29, 2022 · 4 comments
Open

Preferences terminal theme #350

Maartz opened this issue Dec 29, 2022 · 4 comments
Assignees
Labels
bug Something isn't working hacktoberfest #Hacktoberfest Verified Verified bug
Milestone

Comments

@Maartz
Copy link
Member

Maartz commented Dec 29, 2022

Description

Whenever you want to change the theme of the terminal, you can't extend the window the proceed further.

image

That's probably due to the constraints added to the view.

To Reproduce

  1. Open up AE
  2. Cmd + , or AuroraEditor > Settings
  3. Click "Themes"
  4. Click "Terminal"

Expected behavior

The expected behavior is that the window expands to let the user interacts with the content of the view.

Version information

Aurora Editor: 1.0
Commit: 564e893
MacOS: Ventura 13.2
Xcode: 14.2

Additional context

No response

@Maartz Maartz added bug Something isn't working unverified bug report what is not yet verified. labels Dec 29, 2022
@0xWDG 0xWDG added Verified Verified bug and removed unverified bug report what is not yet verified. labels Dec 29, 2022
@0xWDG
Copy link
Member

0xWDG commented Dec 29, 2022

Seems related to #291

@0xWDG 0xWDG added this to the Version 1.0 milestone Dec 29, 2022
@Maartz
Copy link
Member Author

Maartz commented Dec 29, 2022

Right, didn't checked in the closed ones.

@0xWDG
Copy link
Member

0xWDG commented Dec 29, 2022

No problem, i was not able to reproduce it so i expected that it was fixed. seems it's still an issue.
Thanks for the detailed bug report

@Maartz
Copy link
Member Author

Maartz commented Dec 29, 2022

So I've checked this and it seems that it doesn't come from the ThemePreferencesView.
AFAI understand, it's linked to the PreferencesView, especially the settingContentView.
It can't expand its parent frame. So I'd naively tinker with it until find the good balance between readbility and effectiveness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest #Hacktoberfest Verified Verified bug
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants