Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constify some of the methods #137

Open
Kyllingene opened this issue May 6, 2024 · 4 comments
Open

constify some of the methods #137

Kyllingene opened this issue May 6, 2024 · 4 comments

Comments

@Kyllingene
Copy link

I'm currently writing a voxel terrain generator (shush), and naturally I'm using perlin noise for that. Your crate has a very nice API, and thanks to its simplicity, converting most of the methods into const methods should be fairly straightforward.

I'd be glad to PR this myself, if you'd like.

@Auburn
Copy link
Owner

Auburn commented May 6, 2024

Sure, if you want to PR that would be great

@Keavon
Copy link
Contributor

Keavon commented May 6, 2024

Please do submit a PR for this! I'll review it when it's ready, and we can publish a new release after the just-merged #138 and your PR are both landed.

@Kyllingene
Copy link
Author

I'll do that this evening. One thing to note is that while this isn't a breaking change, reverting it will be; I'll take care to mention any possible pain points in my PR.

@Keavon
Copy link
Contributor

Keavon commented May 6, 2024

Yep, as long as we're only adding const (which there shouldn't be any need to revert), this can be a patch release.

@Auburn I think the best way to handle versioning when faced with the many different languages is that you plan to keep the the x.y part of semver's x.y.z format in sync across all ports, but the .z part can freely get out of sync between ports. Maybe the readme can mention that in the part that lists each language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants