Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fade node with checkerboard #15

Open
malytomas opened this issue Dec 29, 2020 · 2 comments
Open

fade node with checkerboard #15

malytomas opened this issue Dec 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@malytomas
Copy link

fastnoise2-broken-fade

Fade node ignores checkerboard connected to the fade factor.

Tested with commit 772a912
Using visual studio 2019. detected avx2

@Auburn
Copy link
Owner

Auburn commented Dec 29, 2020

I think this is because checkerboard returns -1 or 1, and fade is done between 0-1
It might make more sense for fade to use the -1 - 1 range since that is what most noise types output to

@malytomas
Copy link
Author

Alternative solution could be to make the checkerboard node take the two values as inputs.
Or perhaps change both the range of the fade and add the inputs.

Either way, I do not have strong opinion for either solution here. I am just bringing ideas.

@Auburn Auburn added the enhancement New feature or request label Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants