Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in TransportsUtil.java #152

Open
Michenux opened this issue Jul 31, 2017 · 5 comments
Open

Bug in TransportsUtil.java #152

Michenux opened this issue Jul 31, 2017 · 5 comments

Comments

@Michenux
Copy link

Hi,

I think there's a bug in class TransportsUtil.java.

for (Object m : l) {
          return matchDecoder(e, m, nd, decodedObjects);
}

matchDecoder will be invoked only for the first element of the list and the following elements will be ignored.

Not sure but something like this would be better :

ArrayList<Object> list = new ArrayList<>();
for (Object m : l) {
   list.add(matchDecoder(e, m, nd, decodedObjects));
}
return list;
@jfarcand
Copy link
Member

@Michenux Pull request welcomed :-)

@jfarcand
Copy link
Member

Fixed #153

@slovdahl
Copy link
Contributor

slovdahl commented Aug 1, 2017

This sounds similar to the issue I reported in #130, doesn't it? Maybe #130 wasn't properly fixed after all.

@Michenux
Copy link
Author

Michenux commented Aug 1, 2017

Yes, the problem i had is the same as in #130.
Works well with the fix but i tested it only with polling transport.

@thabach
Copy link
Member

thabach commented Aug 2, 2017

There were build test-failures, please reconsider the fix.

@thabach thabach reopened this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants