Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.8.x support #51

Open
solnaranu opened this issue Nov 16, 2021 · 2 comments
Open

Play 2.8.x support #51

solnaranu opened this issue Nov 16, 2021 · 2 comments

Comments

@solnaranu
Copy link

solnaranu commented Nov 16, 2021

Hi,

is there any chance for supporting Play Framework 2.8.x? Several concepts which were deprecated in 2.6.x have been removed/refactored in 2.7 or 2.8. and atmosphere-play cannot be used with 2.8.x.

@jfarcand
Copy link
Member

@solnaranu I don't have the cycle right now, but if you have the time I can review your pull requests, tests and release the new version.

@solnaranu
Copy link
Author

solnaranu commented Nov 16, 2021

@jfarcand thx for the quick reply.

I'd be very glad to contribute, but I would need to get much more familiar with atmosphere-play and Play to be able to pull it off. Also, my cycles are pretty tight too at the moment :)

Biggest problem I see is that play.mvc.Controller no longer has request(), response(), session(), so AtmosphereController and some other code like PlayAsyncIOWriter need to be a bit refactored/redesigned. Some info at Play 2.7 HttpContext Migration.

If you have some pointers on where to begin, it might set out a path to a useful contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants