Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxWebsocketErrorRetries not working as expected #242

Open
mihaisdm opened this issue Jan 18, 2019 · 1 comment
Open

maxWebsocketErrorRetries not working as expected #242

mihaisdm opened this issue Jan 18, 2019 · 1 comment

Comments

@mihaisdm
Copy link

Hello,

I was expecting to try to reconnect using WebSocket until maxWebsocketErrorRetries is reached, after try fallback mechanism.

Should be "_request.curWebsocketErrorRetries++ >_request.maxWebsocketErrorRetries? not less.
Else i do not understand the purpose.

if (_request.curWebsocketErrorRetries++ < _request.maxWebsocketErrorRetries && _request.fallbackTransport !== 'websocket') {

Thank you
Mihai

@SuperPat45
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants