Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow closing the connection if state is OPEN or CONNECTING #206

Closed
wants to merge 3 commits into from
Closed

Allow closing the connection if state is OPEN or CONNECTING #206

wants to merge 3 commits into from

Conversation

yerfinojul
Copy link
Contributor

This was created to fix #205

Basically if the websocket connectTimeout is triggered, but the connection is still established later, there is no way to close the websocket.

I think we should close it anyway as long as the state is OPEN or CONNECTING

@yerfinojul yerfinojul closed this Sep 13, 2016
@yerfinojul yerfinojul reopened this Nov 3, 2016
@yerfinojul
Copy link
Contributor Author

This looks like a simple change @jfarcand but please check, not sure what was the original reason for closing only when canSendMessage was true

@yerfinojul yerfinojul closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's not possible to abort an opening websocket connection
1 participant
@yerfinojul