Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize number of API calls in ConsoleRenderTarget #23

Open
Athari opened this issue Apr 5, 2018 · 0 comments
Open

Optimize number of API calls in ConsoleRenderTarget #23

Athari opened this issue Apr 5, 2018 · 0 comments
Assignees
@Athari
Labels
type:improvement Improvement
Milestone
1.1

Comments

@Athari
Copy link
Owner

Athari commented Apr 5, 2018

Calling Console.Write for every line seems to be unoptimal compared to writing one big block of text. Probably caused by too much interop. See #21 (comment).

Optimize number of API calls in ConsoleRenderTarget for specific cases, like lack of color formating in the document or disabled formatting like discussed in #22.

Optimizations from #11 should make that unnecessary for modern platforms, but generic fallback console writing should be fast too.
@Athari Athari added the type:improvement Improvement label Apr 5, 2018
@Athari Athari added this to the 1.1 milestone Apr 5, 2018
@Athari Athari self-assigned this Apr 5, 2018
@Athari Athari mentioned this issue Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athari Athari

Labels
type:improvement Improvement
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@Athari