Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support current operating system's ANSI codes in AnsiRenderTarget #10

Open
Athari opened this issue Mar 1, 2018 · 0 comments
Open

Support current operating system's ANSI codes in AnsiRenderTarget #10

Athari opened this issue Mar 1, 2018 · 0 comments
Assignees
@Athari
Labels
tag:os-specific Operating system-specific type:feature Feature
Milestone
2.0

Comments

@Athari
Copy link
Owner

Athari commented Mar 1, 2018 •
edited

The current choice of escape codes used by AnsiRenderTarget is pretty much random. Try detecting current system's/terminal's actual escape codes. Investigate what .NET Core does to detect them for switching console colors.

Windows 10 supports escape codes too now. Needs to be enabled with ENABLE_VIRTUAL_TERMINAL_PROCESSING flag in SetConsoleMode. Find out what codes are supported. All related issues are discussed in symfony/symfony#19520.

Also give meaningful names to the commented out color maps and allow to customize them.
@Athari Athari added the type:feature Feature label Mar 1, 2018
@Athari Athari added this to the 2.0 milestone Mar 1, 2018
@Athari Athari self-assigned this Mar 1, 2018
@Athari Athari added the tag:os-specific Operating system-specific label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athari Athari

Labels
tag:os-specific Operating system-specific type:feature Feature
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Athari