Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing captions on last two figures of 10-3 #493

Open
marcozullich opened this issue Sep 3, 2020 · 9 comments
Open

Missing captions on last two figures of 10-3 #493

marcozullich opened this issue Sep 3, 2020 · 9 comments

Comments

@marcozullich
Copy link
Contributor

On 10-3.md the last two figures are missing captions:

  • would-be Fig. 6 (in section "Detailed Model Structure") has the caption superimposed on the image file, but this causes issues in the translated versions since there's only an English sentence which might not be intelligible for the foreign readers
  • would-be Fig. 7 (in section "Examples of Movement"), which is a composition of 4 sub-images, has no caption at all: although the caption is inferrable from the text above, this doesn't seem to fit with the style of the project: as far as I've seen, all figures are numbered and have a caption, even when this is trivially obtainable from the text.
@Atcold
Copy link
Owner

Atcold commented Sep 6, 2020

What do you suggest?

@marcozullich
Copy link
Contributor Author

I could propose a caption for Fig. 7 and update the EN document accordingly, then write in all of the slack groups for regional translations asking to propagate the update.

@Atcold
Copy link
Owner

Atcold commented Sep 11, 2020

Sounds good. Please, proceed.

@marcozullich
Copy link
Contributor Author

See #661

@marcozullich
Copy link
Contributor Author

marcozullich commented Dec 21, 2020

Memo:
Asked for corrections in

I'll be checking them as they're completed

JonathanSum added a commit to JonathanSum/pytorch-Deep-Learning that referenced this issue Dec 21, 2020
@mvcaro
Copy link
Contributor

mvcaro commented Jan 5, 2021

I noticed 10-3 had two different Fig. 5, each under Emulator and Controller sections; the following changes have been made (#743):

  1. 'Fig. 5' under Controller section has now become 'Fig. 6'
  2. Under Controller section 'Refer to Figure 5' has been changed to 'Refer to Figure 6'
  3. 'Fig. 6' under Detailed Model Structure section has been updated to 'Fig. 7' and captions were added
  4. As the figure under Detailed Model Structure section had a caption within the image, the caption within the image has been removed to avoid confusion (pytorch-Deep-Learning-master/docs/images/week10/10-3/fig14.png)
  5. 'Fig. 7' under Detailed Model Structure section has been updated to 'Fig. 8' and captions were added

@marcozullich if you agree with these changes, then 1, 2, 3 and 5 need to be updated across all languages except [EN] and [ES]

@marcozullich
Copy link
Contributor Author

Yep, I'm going for it for IT, will request changes for all other languages. Thanks! @lbourdois @JonathanSum @seungjaeryanlee @i-am-mel-dev would you be so kind as to update the figure numbering as per @mvcaro's comment?

@lbourdois
Copy link
Contributor

lbourdois commented Jan 5, 2021 via email

JonathanSum added a commit to JonathanSum/pytorch-Deep-Learning that referenced this issue Jan 5, 2021
@JonathanSum
Copy link
Contributor

Updated #733

Atcold pushed a commit that referenced this issue Nov 2, 2021
* z̃

* Add week 15

* clean images

* Add files via upload

* clean images

* clean images

* clean images

* clean images

* clean images

* clean images

* clean images

* clean images

* clean images

* clean images

* Add files via upload

* Add files via upload

* clean images

* clean images

* clean images

* clean images

* clean images

* fix markdown

* fix + QA harmonization

* fix markdown

* improved formulation

* fix formulaitons

* QA harmonization

* fix markdown

* forget some correction

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

fix French for #493

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

* v2

fix #778 for French (to think to update #144)

* few corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants