Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify Extending Core Plugin Config Functions #67

Open
academo opened this issue Mar 26, 2023 · 0 comments
Open

Docs: Clarify Extending Core Plugin Config Functions #67

academo opened this issue Mar 26, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@academo
Copy link

academo commented Mar 26, 2023

Is your feature related to a problem?

The existing documentation is not clear on which plugins have a require("plugins.configs.X"). One might assume that all plugins inside astronvim have them but they don't. Which means the plugins that don't have this configuration must be set in a different way.

example:

If you want to set telescope you can follow the example in the official doc but if you want to setup null-ls sources the user_example configuration suggests a different approach https://github.com/AstroNvim/user_example/blob/main/plugins/null-ls.lua

It is not clear to me what happens with the config object returned in the example and how is that related to the code that sets null-ls in astronvim.

In general terms there are really two different ways to extend core plugins and they are not clearly documented.

Describe the new feature

  • A list (or link) pointing to the plugins that have a plugins.configs defined and should follow the require pattern
  • An additional examples for plugins that don't have their own plugin.configs and should follow the opts function pattern.

I understand that you point to the lazy.nvim documentation but the link is to a general readme file and it is hard to know how much of the work is done by lazy.nvim and how much by astronvim code which ends up on multiple trial and error to see what works.

Additional context

Thanks for such a nice work in Astronvim!

@academo academo added the enhancement New feature or request label Mar 26, 2023
@mehalter mehalter transferred this issue from AstroNvim/AstroNvim Mar 27, 2023
@mehalter mehalter self-assigned this Mar 28, 2023
@mehalter mehalter added good first issue Good for newcomers documentation Improvements or additions to documentation help wanted Extra attention is needed and removed enhancement New feature or request labels May 2, 2023
@mehalter mehalter removed their assignment May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants