Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can No Longer Export an Export that Exports from Another File #248

Closed
torch2424 opened this issue Sep 7, 2018 · 5 comments
Closed

Can No Longer Export an Export that Exports from Another File #248

torch2424 opened this issue Sep 7, 2018 · 5 comments

Comments

@torch2424
Copy link
Contributor

torch2424 commented Sep 7, 2018

Hello! It has been a while haha! 馃槃

So after going through and realizing this issue: torch2424/wasmboy#135

I got to catch up on a whole lot of AssemblyScript! 馃槃 So I went through and made the few updates I needed, and realized not all my functions were correctly exporting.

For instance, see this:

Wasmboy Core, index.ts that exports all of our wasminstance exports:
https://github.com/torch2424/wasmBoy/blob/943d79c3cbf525c00a3d73aa2a26a27b7cb24342/core/index.ts

Another file within the core, that exports a function from another file:
https://github.com/torch2424/wasmBoy/blob/943d79c3cbf525c00a3d73aa2a26a27b7cb24342/core/joypad/index.ts

I found that the Wasm instance exports, e.g wasmInstance.exports.myExportFunctionHere were not available. Meaning, I can no longer export functions from a file, that export a function from another file.

It was a quick an easy fix for me, but figured I might as well make an issue. Also, my apologies for the confusing title, it was the only thing I could think of, and gave me a good laugh. Thanks!

@torch2424 torch2424 changed the title Can no Longer Export an Export Can No Longer Export an Export that Exports from another file Sep 7, 2018
@torch2424 torch2424 changed the title Can No Longer Export an Export that Exports from another file Can No Longer Export an Export that Exports from Another File Sep 7, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Sep 7, 2018

File A
 Export a
File B
 Export a from a
Main
 Export a from b // this

That correct? :)

@torch2424
Copy link
Contributor Author

Yes exactly :)

If you have trouble reproducing let me know, as I may have renamed some exports, using export {myFunc as myAwesomeFunc} from './myfile'.

@andy-hanson
Copy link
Contributor

It's possible that #249 fixes this -- though I haven't verified since I didn't see any error on @dcodeIO's simple example in the master branch.

@dcodeIO dcodeIO closed this as completed in 4498b28 Sep 9, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Sep 9, 2018

Test case. Let me know if there are still any issues :)

@torch2424
Copy link
Contributor Author

torch2424 commented Sep 9, 2018

Rad, thanks! I'll update wasmboy with this 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants