Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ i18n / translation ] — asking to contributors #146

Open
ffoodd opened this issue Feb 27, 2018 · 6 comments
Open

[ i18n / translation ] — asking to contributors #146

ffoodd opened this issue Feb 27, 2018 · 6 comments

Comments

@ffoodd
Copy link

ffoodd commented Feb 27, 2018

Hi there!

Since I'm a daily user of contrast-finder, I'd like to participate with i18n
by asking to a11y.css translators some help!

So here they are:

Would you guys be available and volunteer to help translating this application? It is really, really useful since it is, as far as I know, the only web application dedicated to check color contrast which also provides color suggestions when contrast requirements is unmet.

Here is the English version. As you can see, there are less messages than in a11y.css!

Thanks a lot for reading, and if you need any help @dzc34 shall be pleased to give a hand!

Constrast-Finder URL:
https://app.contrast-finder.org

@mfaure
Copy link
Member

mfaure commented Feb 27, 2018

Hey @ffoodd ! Thank you for this help call, this is highly appreciated !

@dzc34 dzc34 added the i18n label Feb 27, 2018
@dzc34
Copy link
Member

dzc34 commented Feb 28, 2018

Hey @ffoodd ! Thank you very much for this boost.

Here is the English version: As you can see, there are less messages than in a11y.css!
webapp/src/main/resources/i18n/contrast-finder_utf8_en.properties

  • The first half of the file (line 1 to line 71) is required for the software.
  • The second part (line 72 to the last line) is less important (user help, ...).
    For example: the Portuguese translation is done for the 1st part but not yet for the 2nd part.

The second part will certainly be modified by the following issue:
#136 Webapp > Help > Text size understanding : comments on pt => px conversion

@dzc34 dzc34 changed the title [i18n] — asking to contributors [ i18n / translation ] — asking to contributors Feb 28, 2018
@dzc34 dzc34 added this to Needs triage in Bug triage Nov 10, 2018
@dzc34 dzc34 moved this from Needs triage to Low priority in Bug triage Nov 10, 2018
@dzc34 dzc34 pinned this issue Dec 30, 2018
@trzepiz
Copy link

trzepiz commented Aug 18, 2019

Hi.

I work on Polish (PL) translate, but I have problem with charset. I use Notepad++ UTF-8
correct is Tło - I have tÅo
correct is wspó�czynnik - I have wspó�czynnik

pl-cf

@dzc34
Copy link
Member

dzc34 commented Aug 18, 2019

hi @trzepiz ,

Can you provide additional information, in particular the "Build info" part of the "about" page: about.html?lang=en ?

ex: http://127.0.0.1:8080/contrast-finder/about.html?lang=en

    version: 0.9.6-SNAPSHOT
    git branch: develop
    git commit: 7691172
    Build:
        date: 2019-08-18T22:14:54+0000
        ID: 0.9.6-SNAPSHOT.7691172.1566166494488
        Platform: Linux amd64, Java 11.0.4, Maven 3.6.0

We are interessed also by the tomcat version and the i18n/contrast-finder_utf8_pl.properties file used (you can push a new commit on your repository or copy the content of this file in this issue).


I tested the Polish characters (based on Polish alphabet from Wikipedia) and it works with my local build.

Ą Ć Ę Ł Ń Ó Ś Ź Ż  
ą ć ę ł ń ó ś ź ż  
Zażółć gęślą jaźń  

screenshot of the Polish specific character test


I also initialized somes files for Polish (PL) translation in a dedicated branch:
https://github.com/Asqatasun/Contrast-Finder/commits/i18n_PL

if you need help, don't hesitate to contact us.

@trzepiz
Copy link

trzepiz commented Aug 19, 2019

Hi.
Tomcat

root@vps:/usr/share/tomcat8/bin# ./version.sh
Using CATALINA_HOME:   /usr/share/tomcat8
Server built:   Apr 10 2019 04:45:09 UTC
Server number:  8.5.39.0
JVM Version:    1.8.0_212-8u212-b03-0ubuntu1.18.04.1-b03

Build info

version: 0.9.5
git branch: master
git commit: b3d5375
Build:
    date: 2019-05-01T15:33:46+0000
    Platform: Linux amd64, Java 1.8.0_191, Maven 3.3.9

I change WEB-INF\classes\i18n\contrast-finder_utf8_en.properties file. Problem is the same

cf-pl

@dzc34
Copy link
Member

dzc34 commented Aug 19, 2019

hi,

Before maven build, character encoding of i18n files is UTF-8. But after build (in the .war file or in tomcat directory), character encoding of i18n files is ISO-8859-1 with UTF8 entities instead of missing characters (such as: ą ć ę ł ń ó ś ź ż).


Before Maven build (UTF-8),
webapp/src/main/resources/i18n/contrast-finder_utf8_fr.properties file in git repository:

form.contrastSolutionBackground=Arrière plan
form.sampleText=Ceci est un échantillon de texte

After Maven build (ISO-8859-1 with UTF8 entities),
WEB-INF\classes\i18n\contrast-finder_utf8_fr.properties file in the .war file or in Tomcat directory:

form.contrastSolutionBackground=Arri\u00E8re plan
form.sampleText=Ceci est un \u00E9chantillon de texte

The modifications made in the WEB-INF\classes\i18n\contrast-finder_utf8_fr.properties file may be lost after the restart of Tomcat. The best solution is to work on the code of the git repository and build the.war file with Maven.

The easiest solution for you (without compiling with maven) is to you modifing the i18n/contrast-finder_utf8_pl.properties file directly in Github and I can include Polish translate in the next release scheduled at the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug triage
  
Low priority
Development

No branches or pull requests

4 participants