Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good start on the React API project #2

Open
soggybag opened this issue Feb 10, 2019 · 0 comments
Open

Good start on the React API project #2

soggybag opened this issue Feb 10, 2019 · 0 comments

Comments

@soggybag
Copy link

Good start on the React API project. This still needs work to get it across the finish line.

I notice that you have a Weather component. Good work. Currently you are returning <Weather /> from App.renderWeather(). Weather expects some props that seem to be missing here. Something like

<Weather temp={temp} />

I see an error

./src/components/weather.js
Line 3: Your render method should have a return statement

Looks like you need a return in Weather.render(). Better to make this component a functional/stateless component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant