Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions can be set in a more convienent way. #409

Open
tristansokol opened this issue Feb 12, 2024 · 0 comments
Open

Permissions can be set in a more convienent way. #409

tristansokol opened this issue Feb 12, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@tristansokol
Copy link

Describe

Hi! I initially abandoned setting this up after running into the Resource not accessible by integration issue, as the suggested pull_request_target seemed not very good. However, working with another action showed me that you can set permissions with something like

    permissions:
      # Required to checkout the code
      contents: write
      checks: write
      # Required to put a comment into the pull-request
      pull-requests: write

I think this is a preferred option (at least for uses cases where the PRs are all from internal branches.) compared to what is currently shown as an option to fix this issue.

Additional context

Additionally the check seemed to work just fine with contents: read & pull-requests: write aside from the failing API calls (tests were ran, coverage comment was made) and these permissions line up with other similar actions (https://github.com/marketplace/actions/vitest-coverage-report) Is there a reason why this action requires additional permissions? Maybe we could document them in the same spot.

Thanks!

@tristansokol tristansokol added the documentation Improvements or additions to documentation label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant