Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests #31

Open
ofekkr1 opened this issue Mar 20, 2023 · 3 comments
Open

Adding unit tests #31

ofekkr1 opened this issue Mar 20, 2023 · 3 comments
Assignees
@ofekkr1
Labels
enhancement New feature or request

Comments

@ofekkr1
Copy link
Collaborator

ofekkr1 commented Mar 20, 2023

Feature

As more features are being added to the calculator, we need to make sure that everything that was added before, is still working as intended.

Solution

This can be solved by adding unit tests from qt itself(although adding tests to an existing project is quite hard in qt).
@ofekkr1
Copy link
Collaborator Author

ofekkr1 commented Mar 20, 2023

@Arsenic-ATG May I work on this one?

@ofekkr1 ofekkr1 closed this as completed Mar 20, 2023
@ofekkr1 ofekkr1 reopened this Mar 20, 2023
@Arsenic-ATG Arsenic-ATG added the enhancement New feature or request label Mar 21, 2023
@ofekkr1 ofekkr1 mentioned this issue Mar 23, 2023
Merged
@ofekkr1
Copy link
Collaborator Author

ofekkr1 commented Mar 23, 2023

@Arsenic-ATG I made a new PR at #32 , but the tests are still not automated(there is no direct way to test qt with github workflow, only with Cmake which has its own bugs on qt).

@ofekkr1
Copy link
Collaborator Author

ofekkr1 commented Mar 28, 2023

Anyone who wants to work on this issue, is more then welcome to try.
Just make sure you write here before, so people wont work on the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofekkr1 ofekkr1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arsenic-ATG @ofekkr1