Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACKER - 16-bit depth viewports needed for improved flowmap calculation (BLOCKED by Godot 4.0) #19

Open
Arnklit opened this issue Nov 25, 2022 · 2 comments

Comments

@Arnklit
Copy link
Owner

Arnklit commented Nov 25, 2022

Godot 4.0 does not have 16-bit viewports yet, which means I cannot calculate flowmaps and various other textures correctly.

There is a PR working on it, but it is stale. godotengine/godot#61667

EDIT: It turned out I had some bugs in my code that made the problem worse, fixing those issues made it doable to generate the flowmaps, thought they will be better with 16 bit viewports. I might also move away from using Viewports and use Render Device directly, but that will require quite a bit of work.

Keeping the bug open now to track the issue.

@Arnklit Arnklit changed the title TRACKER - 16-bit depth (HDR) viewports needed for proper flowmap calculateion (BLOCKED by Godot 4.0) TRACKER - 16-bit depth (HDR) viewports needed for proper flowmap calculation (BLOCKED by Godot 4.0) Nov 25, 2022
@TokisanGames
Copy link

This proposal discusses plans for 16/32-bit viewports.

godotengine/godot-proposals#2935

11 days ago here clayjohn said, "3D rendering still happens in HDR (16bpc)... We have a plan to expose a way to get the HDR buffer directly from the viewport... Ultimately though, for custom effects we expose the ability to create your own framebuffers and textures through the RenderingDevice directly so you don't have to go through the Godot pipeline."

Can you create your own frame buffer as he says?

@Arnklit
Copy link
Owner Author

Arnklit commented Nov 29, 2022

Yes I think I can. Me and Rod (creator of Material Maker) have been discussing this. It will probably be needed for some of the more advanced stuff I want to add to Waterways, but for now I've actually gotten it to work with the 8-bit viewports.

@Arnklit Arnklit changed the title TRACKER - 16-bit depth (HDR) viewports needed for proper flowmap calculation (BLOCKED by Godot 4.0) TRACKER - 16-bit depth viewports needed for improved flowmap calculation (BLOCKED by Godot 4.0) Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants