Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it configurable whether we reset timestamps and ids in fixtures #3101

Open
axiomofjoy opened this issue May 6, 2024 · 0 comments
Open
Labels

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented May 6, 2024

  • make it configurable whether we reset span ids and timestamps on trace fixtures. needed because having stable timestamps is useful for testing against features. something like a --reset-ids-and-timestamps command line argument to the trace-fixture command would be helpful.
  • ensure that spans from trace fixtures are inserted into the db in (roughly) chronological rather than reverse chronological order. needed because otherwise, the fixture winds up having rowids that decrease over time, which is unrealistic and makes it difficult to test features such as pagination.

for reference, this is how i am currently getting around this issue in the pagination pr: 389bc5b#diff-bedd740bede03d53ccfd0df1d998bff39a53e43ea041a9fac2911beb90d5682b

@axiomofjoy axiomofjoy added enhancement New feature or request triage issues that need triage and removed enhancement New feature or request triage issues that need triage labels May 6, 2024
@dosubot dosubot bot added c/traces enhancement New feature or request labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📘 Todo
Development

No branches or pull requests

2 participants