Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comdirect apps + sonos icon updates #2117

Open
ChaosNicro opened this issue May 9, 2024 · 4 comments
Open

comdirect apps + sonos icon updates #2117

ChaosNicro opened this issue May 9, 2024 · 4 comments

Comments

@ChaosNicro
Copy link

Hey there,

Just wanted to note that the comdirect banking-app has an icon, but is not auto-detected correctly. The Tan-app for it does not have an icon yet but the auto-generated path-tracing is very good and might be usable as-is.

I also just noticed that Sonos does not apply it's icon automatically.

Here are the relevant info-blocks:

comdirect
de.comdirect.app/de.comdirect.core.feature.splash.SplashActivity
https://f-droid.org/en/packages/de.comdirect.app/

photoTAN
com.comdirect.phototan/de.comdirect.phototan.feature.splash.impl.SplashActivity
https://f-droid.org/en/packages/com.comdirect.phototan/

Sonos
com.sonos.acr2/com.sonos.passport.ui.launcheractivity.LauncherActivity
https://f-droid.org/en/packages/com.sonos.acr2/

Kaiserdragon2 added a commit to Kaiserdragon2/Arcticons that referenced this issue May 17, 2024
@Kaiserdragon2
Copy link
Collaborator

I have added the comdirect app and the Sonos one to the appfilter file these should work in the next release.
For the PhotoTan it might be best to request it through the Arcticons app or draw it yourself.

@wwwwwwari
Copy link
Contributor

I added photoTAN in #2128 since I think it's still available at Google Play with the exact component string.

@ChaosNicro
Copy link
Author

I added photoTAN in #2128 since I think it's still available at Google Play with the exact component string.

Thanks for picking this up, looks good. Though I would suggest keeping the "C" as an outline instead of a single line, that way it can match the main app.

@wwwwwwari
Copy link
Contributor

wwwwwwari commented May 21, 2024

I can change the shape of the C to look like the original icon instead of using the Arcticons font. The changes won't be in this release, though.

Unless someone (not me) can do it before the very soon release, that is. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants