[Day & Night] Add icon and its own screeenshots to F-droid

[inson1]

No description provided.

[Donnnno]

Need a bit more details, about what version are we talking?

[inson1]

@Donnnno sorry

[Donnnno]

Thanks, I'll look in to it!

It probably could use its own screenshots too

[petlyh]

The problem is likely caused by the icon file in the Day & Night metadata being in WEBP format, while F-Droid only supports PNG and JPEG.

[TotallyAvailable]

Which would be weird given how it got there during #1847

Well maybe not so weird after all and there are indeed some .webps among the usual pngs.

Scrolling through the F-Droid repo, certainly not that uncommon.

[petlyh]

Scrolling through the F-Droid repo, certainly not that uncommon.

Could you give an example of that?

[TotallyAvailable]

I would say probably not in a reliable way as I'm (currently) not using the official client.

[Donnnno]

https://gitlab.com/fdroid/fdroidclient/-/issues/2758

[petlyh]

https://gitlab.com/fdroid/fdroidclient/-/issues/2758

I think it's a good idea for F-Droid to support WEBP images, though you should probably open the issue in fdroid/fdroidserver instead.

It's not that the F-Droid client or your browser doesn't support WEBP images (necessarily), it's that the F-Droid server doesn't copy WEBP images from the app source code repository to the F-Droid repository. The client doesn't fail to load the image, there is no image in the repo for the client to load.

fdroidserver only copies PNG and JPEG files from play/listings/ (Triple-T structure):
https://gitlab.com/fdroid/fdroidserver/-/blob/7211e9f9b43433154231ce25ef7f724ed9933fc3/fdroidserver/update.py#L996
https://gitlab.com/fdroid/fdroidserver/-/blob/7211e9f9b43433154231ce25ef7f724ed9933fc3/fdroidserver/update.py#L96

And only PNGs from res/:
https://gitlab.com/fdroid/fdroidserver/-/blob/7211e9f9b43433154231ce25ef7f724ed9933fc3/fdroidserver/update.py#L1391

[Donnnno]

Thanks @petlyh there's already an issue open, but with no activity for a year. Probably a good thing to give it a thumb to raise awareness!

https://gitlab.com/fdroid/fdroidserver/-/issues/984