Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quite a few icons, that have circles with r<1r!=0.75 #1805

Open
quantenzitrone opened this issue Nov 16, 2023 · 11 comments
Open

Quite a few icons, that have circles with r<1r!=0.75 #1805

quantenzitrone opened this issue Nov 16, 2023 · 11 comments

Comments

@quantenzitrone
Copy link
Contributor

quantenzitrone commented Nov 16, 2023

most of these are probably errors, some may be intentional:

0.8507 : _1xbit.svg
0.7999 : _5_in_1.svg
0.7472 : _1822_direkt.svg
0.7742 : act_fibernet.svg
0.7506 : agoda.svg
0.825 : aircare.svg
0.7 : amazon_music.svg
0.7 : amazon_prime_video.svg
0.7821 : aplayer.svg
0.7472 : appmgr_iii.svg
0.7 : apps2fire.svg
0.9286 : aranet.svg
0.7 : ariane2.svg
0.8 : asn_bankieren.svg
0.8 : bolt.svg
0.5566 : chimera_recollect.svg
0.3701 : chrono_trigger.svg
0.7499 : circloo.svg
0.8 : cnn_turk.svg
0.9042 : coffee_golf.svg
0.7472 : coindcx_bitcoin.svg
0.775 : coingecko.svg
0.8336 : combide.svg
0.5 : concentricclock.svg
0.3331 : darkmodelivewallpaper.svg
0.4792 : digiturk_online.svg
0.4792 : digiturk_play.svg
0.4792 : digiturk_sinyal.svg
0.7502 : ditmm.svg
0.8 : droidvim.svg
0.8 : dslrdashboard.svg
0.7488 : ecoledirecte.svg
0.7 : firetv.svg
0.7517 : flic.svg
0.7472 : flip_transfer.svg
0.25 : foss_warn.svg
0.7198 : fritz_app_wlan.svg
0.5209 : genshin_impact.svg
0.71 : gif_live_wallpaper.svg
0.8 : hamradiotools.svg
0.7 : hepsiburada.svg
0.9 : hidemevpn.svg
0.5 : i2pd.svg
0.795 : incognitowallet.svg
0.8 : isotopebrowser.svg
0.8 : istegelsin.svg
0.7 : jersey_mikes.svg
0.9774 : keyoxide.svg
0.66 : kinoteatr.svg
0.5867 : kitchenowl.svg
0.948 : koton.svg
0.8 : landroid.svg
0.3788 : libary.svg
0.675 : liftago.svg
0.7496 : like_a_dino.svg
0.8 : mathtricks.svg
0.7 : mavi.svg
0.8734 : metrictime.svg
0.7842 : michelin.svg
0.634 : monefy.svg
0.9666 : money_lover.svg
0.8 : moneywallet.svg
0.7319 : monpetitgazon.svg
0.9508 : moon_phase.svg
0.65 : myswordforandroid.svg
0.692 : nafath.svg
0.8364 : nothing_weather.svg
0.7501 : opsu_.svg
0.9873 : orloj.svg
0.7499 : pccovid.svg
0.9552 : plant_vs_zombie_2.svg
0.9552 : plants_vs_zombies.svg
0.8569 : pocket_fm.svg
0.7502 : printbot.svg
0.7497 : pubg_mobile.svg
0.5 : pulseaudiortpreceiver.svg
0.7498 : quick_dice_roller.svg
0.82 : rabbitescape.svg
0.7499 : reuters.svg
0.8409 : rtrnettest.svg
0.795 : samsungpaymini.svg
0.7 : sanitas_portal.svg
0.3 : setedit.svg
0.8 : shadereditor.svg
0.4692 : soulknight.svg
0.5 : stellarium.svg
0.5 : stellariumfree.svg
0.6423 : tiny_planet_fx_pro.svg
0.9401 : toon_blast.svg
0.7905 : tpbank_etoken.svg
0.9 : trainline.svg
0.2103 : tribal_wars.svg
0.7498 : uno.svg
0.7532 : verkehr_nrw.svg
0.7 : videlibri.svg
0.795 : virginmoney.svg
0.7659 : vtv_go.svg
0.73 : yourphone.svg

Total count: 98

Script to get this result (fish shell):

for i in *
    set r (cat $i | grep -Po '<circle .*?>' | grep -o 'r="[0]*\.[0-9]*' | cut -c 4- | sed 's/^\./0./g' | head -n1)
    if test "$r" != "" && test "$r" != "0.75"
        echo $r : $i
    end
end
@quantenzitrone quantenzitrone changed the title Quite a few icons, that have circles with r<1 && r!=0.75 Quite a few icons, that have circles with r<1r!=0.75 Nov 16, 2023
@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 16, 2023

Besides the 'E' sticking out more than necessary, Verkehr.NRW would absolutely get a seal of approval from me.

Isotopebrowser is difficult.

There are a few more but I think that's not the point (of personal opinions), guidelines exist for a reason.
Should a few be left as is, if so who decides, certainly not me.

Also thanks for bringing it up in such a condensed form.
Might feed into #1804

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 16, 2023

I had my suspicions, 1,5px should be the case for every icon.

@quantenzitrone
Copy link
Contributor Author

image
bruh

@quantenzitrone
Copy link
Contributor Author

Actually, all non-filled dots with sizes above 0.5 have a hole (assuming all icons have line-width=1px correctly), and thus are valid.

@quantenzitrone
Copy link
Contributor Author

image
for example the smaller dots here have r=0.929

@quantenzitrone
Copy link
Contributor Author

oh shit some of the wrong-dot-radius-icons are my doing 😬

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 16, 2023

Nothing wrong with the last example, right?

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 16, 2023

oh shit some of the wrong-dot-radius-icons are my doing 😬

Same for me 😅

@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 16, 2023

Sounds like a "The reworkening" incoming.
I also can no longer unsee the issue with the Foss Warn dot...

@quantenzitrone
Copy link
Contributor Author

Nothing wrong with the last example, right?

yes it was an example of r<1 being acceptable

@Kaiserdragon2
Copy link
Collaborator

I had my suspicions, 1,5px should be the case for every icon.

the thing is the script checks the radius and the 1.5px is the width and height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants