This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix prompt being shown twice (#96) #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason (as I can see it): The interpolation of the request params is done twice. Both interpolations were called using the context RENDER_PURPOSE_RENDER which triggers the prompt in `local-template-tags.ts`. This file contains the "prompt" function as a plugin. `context.app.prompt` is called there without checking for the already set cached value when context === "send". This "fix" renders the first time with renderPurpose set to "no-render" so no prompt is called in this case since no plugins (the "prompt") are called anyway.
|
thanks! sounds good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason (as I can see it):
The interpolation of the request params is done twice. Both interpolations were called using the context RENDER_PURPOSE_RENDER which triggers the prompt in
local-template-tags.ts.This file contains the "prompt" function as a plugin.
context.app.promptis called there without checking for the already set cached value when context === "send".This "fix" renders the first time with renderPurpose set to "no-render" so no prompt is called in this case since no plugins (the "prompt") are called anyway.
This might have side effects I have not encountered so far!
Closes #96
ps. A version for mac (universal) that incorporates this fix is here: https://github.com/thenoseman/insomnium/releases/tag/fix-double-prompt-test-release
This is just for testing purposes and should not be used longterm!