Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot view or delete a record that contains Map data #34

Open
chasevida opened this issue Jun 9, 2019 · 7 comments
Open

Cannot view or delete a record that contains Map data #34

chasevida opened this issue Jun 9, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@chasevida
Copy link

Describe the bug
Cannot expand (view as a modal) or delete a record row that contains DynamoDB Map data.

To Reproduce
Steps to reproduce the behaviour:

  1. Ensure you have a DynmoDB table that includes one attribute who's schema is of type Map.
  2. Create a record with values for that map and persist it in DynamoDB
  3. Navigate to the table in the DynamoDb Gui
    4.a Double click the record in the table list view
    5.a The record should display in the modal but in actuality the modal displays empty/no record data.
    4.a Click the rows trash icon in order to delete the record
    4.b Click confirm delete - it does not delete the record

Expected behavior

  1. When clicking a record row, that contains 'map' data, it should display that data in the modal view.
  2. When click the trash (delete icon) for a record row, that contains 'map' data, it should delete that record upon confirmation.

Screenshots

The below shows a record containing 'map' data.

Screen Shot 2019-06-10 at 8 56 34 AM

The below shows what the record displays as when expanded into the modal view. You can see that it shows as empty instead of showing the nested data structure.

Screen Shot 2019-06-10 at 8 56 42 AM

The delete operation does not work on this row either.

Screen Shot 2019-06-10 at 8 56 50 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
I'd be keen to help solve this and have started looking through the code. It just may take me a little while to get familiar with the setup and understand how Vue works.

Thank you
I just wanted to say a big thanks for this DynamoDB Gui. I tried a few alternatives before landing on this and I really appreciate the effort you have put in. It's a great client and it's a pleasure to work with. Thanks!!!

@Arattian
Copy link
Owner

Arattian commented Jun 10, 2019

@chasevida Thanks for warm words. I wish you to know that i made this GUI when i had no experience in development. Now i get some and i think i need to rewrite some weird parts of this app. I will investigate the bug soon, i think that there is a problem when passing data to editor. Can you please switch to 'code' mode of the editor and make sure if it's empty too?
59164480-58d5b580-8b61-11e9-8d81-15dea24e56e4

All fixes and new features will be released this weekend.

@Arattian Arattian added the bug Something isn't working label Jun 10, 2019
@chasevida
Copy link
Author

Thanks @Arattian, I'm really impressed you did this with no experience before hand - nice job! It's definitely the nicest Gui for DynamoDB that I've found so you've done well pulling it all together. I tried the code view as suggested but it did not appear to display anything either (see below). I'll try and take a look through and see if I can find the fix. Again really appreciate what you've done.

Screen Shot 2019-06-11 at 2 48 30 PM

@Arattian
Copy link
Owner

@chasevida Thanks a lot. I am reviewing this too, I hope to fix this within the next release at the weekend.

@chasevida
Copy link
Author

No pressure from me by the way, appreciate this is open source and as such your time. Just thought I'd log it here and if I get a chance to fix it before you I'll make a PR.

@Arattian
Copy link
Owner

There will be no release this week. I decided to rewrite the project, to make it easy to contribute. Please be patient :) Thanks for understanding.

@chasevida
Copy link
Author

No worries. Let me know if there is anything I can help with.

@Nashuim
Copy link

Nashuim commented Jul 12, 2019

I investigated this bug a bit since I hit a similar one and I don't believe that this is related to Map data but rather number/non string keys.

In my case, and I believe in @chasevida's case as well, we're using a number that's too large to be represented by Javascript, which means that details will be lost when using the DocumentClient to get or update the data.

What is likely happening is that we fail to get the record while opening the modal which leads to an empty one. It'd also explain delete failing since delete would require the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants