Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: allow adding optional id to the body tag #439

Open
1 task done
nhi-vanye opened this issue May 14, 2023 · 1 comment
Open
1 task done

[Feature]: allow adding optional id to the body tag #439

nhi-vanye opened this issue May 14, 2023 · 1 comment

Comments

@nhi-vanye
Copy link

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Description

I'm trying to override some formantic-ui CSS and stackoverflow suggestions (https://stackoverflow.com/questions/55005996/overriding-styles-in-semantic-ui-react) are to add a id tag close to top of the hierarchy.

Problem

Easier overriding of CSS

Proposed Solution

Add optional parameter to SemanticPage body_id

Alternatives Considered

Adding additional divs, but didn't produce hierarchy as nabber (formantic.plus) has its own idea of document structure and I want my CSS to be across both nav bar and main content...

@nhi-vanye
Copy link
Author

I an id attribute was always added to body (i.e. default = "app"), even if the SemanticPage call was hidden inside navbar_page I could still override it with htmltools::addTagsAttributes while I work on PR for an improved navbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant