Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dependency on JExcelAPI #44

Open
benoitx opened this issue Jul 22, 2018 · 3 comments
Open

Remove Dependency on JExcelAPI #44

benoitx opened this issue Jul 22, 2018 · 3 comments
Assignees
@benoitx
Labels
enhancement

Comments

@benoitx
Copy link
Contributor

benoitx commented Jul 22, 2018

The ExcelTransformer is the only class in Flatpack depending on JExcelAPI.

I suggest that we move that class into a 'flatpack-excel' module.
@benoitx benoitx self-assigned this Jul 22, 2018
benoitx added a commit that referenced this issue Jul 24, 2018
@benoitx
#44 Remove JExcelAPI Dependency
77e3c7e
@benoitx
Copy link
Contributor Author

benoitx commented Jul 24, 2018

Suggest that we change the ExcelTransformer to be a Writer.

@martindiphoorn
Copy link
Collaborator

If it is being rewritten then maybe think about using an other library.
JExcelApi latest version is from 2009 and there site is dead, only sourceforge is a live.

I would suggest using apache poi.

martindiphoorn added a commit to martindiphoorn/flatpack that referenced this issue Nov 22, 2018
@martindiphoorn
Appendium#44 FlatPack poi example
0363320
@martindiphoorn
Copy link
Collaborator

Just added a simple poi example which can be easily extended. Be aware that i needed an outputstream so i hacked it into the factory.

See this commit:
martindiphoorn@0363320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitx benoitx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benoitx @martindiphoorn