Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buckets don't seem to work properly #732

Open
serjou1 opened this issue May 24, 2022 · 0 comments
Open

Buckets don't seem to work properly #732

serjou1 opened this issue May 24, 2022 · 0 comments

Comments

@serjou1
Copy link

serjou1 commented May 24, 2022

There's a couple of things that confuses me about bucket histogram. Update method from IMeasureBucketHistogramMetrics has following signature:
void Update(BucketHistogramOptions options, long value);

While BucketHistogramOptions has following property:
public IEnumerable<double> Buckets { get; set; }

I guess it should be:
public IEnumerable<long> Buckets { get; set; }
or update method should be changed to
void Update(BucketHistogramOptions options, double value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant