Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use apply() instead of commit() for default preferences #618

Open
coldcode001 opened this issue Jan 25, 2024 · 0 comments
Open

Should use apply() instead of commit() for default preferences #618

coldcode001 opened this issue Jan 25, 2024 · 0 comments

Comments

@coldcode001
Copy link

There's not any reason to use #commit() to save such trivial preferences to default preferences. Actually we should always use apply() here.
There are 4 improper usages in GoogleMediationAdapter.java and GoogleAdManagerMediationAdapter.java, please fix them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant