Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: When editing a "summary" of an operation, the edit control doesn't close when selecting a different operation #606

Closed
EricWittmann opened this issue Jan 18, 2019 · 4 comments

Comments

@EricWittmann
Copy link
Member

Steps to reproduce:

  1. Click on a path with at least 2 operations.
  2. Click the summary of an operation to start editing it
  3. Click a different operation

Note that the summary control inline editor remains (with the old value!). The inline editor should close on a selection event. All inline editors should close whenever a selection event is fired.

@JulienGoldman
Copy link

Hello Eric,

Same issue on every inline editors I think.
I reproduce this issue with data type example.

image

@EricWittmann
Copy link
Member Author

Thanks for the update @JulienGoldman - this is not surprising but very good to know! I think it should be an easy fix and I have a couple of ideas...just need to decide on the best approach. I think there are three (at least) possible solutions:

  1. watch for click events outside the editor
  2. close the editor if the @input changes
  3. close when the user changes their selection (there is an application event for this)

None of the solutions are hard to implement.

@EricWittmann
Copy link
Member Author

Note: I'm just in the middle of upgrading from angular 5 to angular 7, and I'm out on vacation all next week. But after that I should be getting back to some bug fixes, this included.

@EricWittmann
Copy link
Member Author

I think option (2) above is the easiest to implement and the most correct. So am going to try doing that now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants