-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable To Link Enterprise Github With Apicurio #1345
Comments
Also, this github is internal of our organisation : https://gecgithub01.walmart.com/ |
The screenshot for the OAuth application didn't come through. I can't tell from the 404 github page what might be wrong. However, Keycloak has some additional documentation on this here: https://www.keycloak.org/docs/latest/server_admin/index.html#github Have a look at that and see if it helps. Without more information (e.g. screenshots of the actual configuration params in Keycloak and Github) I can't be of more help. :( |
Ah ha! I didn't put that together initially. You are trying to integrate with an instance of GitHub Enterprise, not with github.com. I thought you were referring to a private organization on github.com. My mistake. So yeah - you will need some different configuration. Instead of configuring a github.com identity provider in Keycloak, you will need to configure a OpenID Connect v1.0 identity provider instead. The good news is that I'm confident this is possible to do without much trouble. The bad news is that I don't have this specific use-case documented, because I don't have access to a GitHub Enterprise installation that I can use to test and verify the configuration steps. We do have documentation on how to configure a local GitLab server, which is exactly what you want to do but with GitHub Enterprise instead of GitLab CE. Here is the GitLab article for reference: https://www.apicur.io/studio/docs/using-a-local-installation-of-gitlab You could try to adapt the information in that article for your situation. To make this even more complicated (I hope I'm not scaring you away), there is an issue with using the Keycloak OpenID Connect identity provider type with GitHub Enterprise. The problem is discussed here: #831 We have a solution to that problem in the form of a custom Keycloak extension that provides a configurable version of the standard GitHub Keycloak social connector. You can find that extension (with Readme documentation) here: https://github.com/Apicurio/apicurio-keycloak-extensions Ignore the GitLab section of the readme and focus on the GitHub section. 👍 |
@EricWittmann Sorry but I have few basic questions :
|
For GitHub there are two environment variables you must set (or you can use system properties). These are: https://github.com/Apicurio/apicurio-studio/blob/master/back-end/hub-core/src/main/java/io/apicurio/hub/core/config/HubConfiguration.java#L46-L50 You can either use the environment variable approach or the system property approach. If using env vars, something like this:
If you want to use system properties you can either add them to the right place in the
|
I realize you're just trying to get this working (step 1) but I wanted to mention that it's not recommended to use the Quickstart in production. That's intended to be an evaluation deployment (get started fast). If your plan is to run something in production, I would strongly suggest doing so using the docker images (either via docker compose, kubernetes, or OpenShift). |
Okay. Thanks a lot @EricWittmann |
@EricWittmann And then i am using this command to start my local keycloak instance : But still the GitHub Enterprise is not getting listed in the Identity providers dropdown. |
Do I need to take some other action as well? |
What version of Keycloak are you using? I'll try to reproduce. |
Note: it's possible that you don't have GitHub in that list because you already have a GitHub social connector created. Maybe try deleting that one and seeing if the dropdown changes? I think this because I don't see either "GitHub" entry in the list. And they both have the same built-in value for "provider id" of |
@EricWittmann |
OK great! It sounds like you have things going OK. I'm going to close this for now but please feel free to re-open it if you need additional support. Also if you get everything working the way you want, please consider contributing documentation for how to configure Studio with GitHub Enterprise. It would be very appreciated! :) |
Surely I would be glad to contribute in the documentation for github enterprise as we have things working as expected. |
That would be amazing, thanks! The Studio documentation is located here: https://github.com/Apicurio/apicurio.github.io/tree/master/_pages/studio/docs I would suggest making a copy of |
@EricWittmann |
That's great! If you wanted to fork that repository and then submit a PR that would be great. If you want to attach the file to this issue or email it to me, that's fine too (my email address is in my GitHub profile). |
Hi @EricWittmann |
Fantastic, thanks so much! |
Hi,
I followed : https://www.apicur.io/studio/docs/setting-up-keycloak-for-use-with-apicurio in order to have our Github as an identity provider with APicurio running locally in our system.
We can see the login option with github is there :
But on clicking the Github login option, We are getting redirected here :
Can you please help on what might have gone wrong?
The text was updated successfully, but these errors were encountered: