Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI check that enforces the formatting #246

Open
keunes opened this issue May 21, 2023 · 1 comment
Open

CI check that enforces the formatting #246

keunes opened this issue May 21, 2023 · 1 comment
Labels
new New elements or building blocks to be added to the website

Comments

@keunes
Copy link
Member

keunes commented May 21, 2023

Short description: Add a CI check that enforces the formatting, especially indent (number of spaces)

Location: site-wide

Why have this: It helps make/keep the code-base readable.

More info: I think we might want some includes to start at an indent bigger than 0, so that they integrate nicely in the output code. We may want to find a tool that's capable of handling this.

We'll also want to check only files touched by the commits/PR.

@keunes keunes added the new New elements or building blocks to be added to the website label May 21, 2023
@keunes
Copy link
Member Author

keunes commented May 21, 2023

@ByteHamster @Rotzbua Maybe this could help us? https://github.com/cebe/indent

Or https://github.com/marketplace/actions/prettier-code-formatting / https://prettier.io/

Edit: since Prettier takes EditorConfig introduced in #244, that might be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New elements or building blocks to be added to the website
Projects
None yet
Development

No branches or pull requests

1 participant