Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 5.3+ #203

Open
keunes opened this issue Nov 29, 2022 · 5 comments
Open

Upgrade to Bootstrap 5.3+ #203

keunes opened this issue Nov 29, 2022 · 5 comments
Labels
new New elements or building blocks to be added to the website

Comments

@keunes
Copy link
Member

keunes commented Nov 29, 2022

Short description: Upgrade Bootstrap to version 5.3 or later, when it is released.

Location:

Why have this: It 'natively' supports Dark mode 🎉 This will decrease the need for custom CSS. And it will undoubtedly bring other improvements as well.

More info:
twbs/bootstrap#35857 (comment)

@keunes keunes added the new New elements or building blocks to be added to the website label Nov 29, 2022
@ByteHamster
Copy link
Member

ByteHamster commented Jan 14, 2023

Also, building now gives these warning messages because of the outdated bootstrap:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2) or calc($spacer / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
717 │ $navbar-padding-y:                  $spacer / 2 !default;
    │                                     ^^^^^^^^^^^
    ╵
    .../antennapod.github.io/_sass/bootstrap/_variables.scss 717:37  @import
    bootstrap/bootstrap.scss 9:9                                                               @import
    .../antennapod.github.io/assets/css/main.scss 4:9                root stylesheet

@Rotzbua
Copy link
Contributor

Rotzbua commented Jul 26, 2023

Another advantage is the removal of jQuery dependency. For custom code this can be done upfront.
Reference: https://getbootstrap.com/docs/5.3/migration/#dependencies

@keunes
Copy link
Member Author

keunes commented Sep 2, 2023

Hi @Rotzbua,
With #203 done, are we ready to start working on this? (If yes, I'm wondering how to approach this. Maybe we should see if we can drop more custom CSS? Also, would you be up for a call to discuss the site/this upgrade in person?)

@keunes
Copy link
Member Author

keunes commented Dec 4, 2023

Hi @Rotzbua, kind reminder. Are you interested in working in this? I would love to work on this and get this done :-) (if no time or interest, please don't hesitate to mention that also)

@Rotzbua
Copy link
Contributor

Rotzbua commented Dec 19, 2023

@keunes I will have a look around Christmas and new year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New elements or building blocks to be added to the website
Projects
None yet
Development

No branches or pull requests

3 participants