Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate list of languages for which to create localised screenshots #2

Open
keunes opened this issue May 10, 2024 · 1 comment
Open

Comments

@keunes
Copy link
Member

keunes commented May 10, 2024

The list of languages to consider for screenshot creation is currently manually identified:

createScreenshots "en-US"

It'd be better to automate that, so we don't have to think about keeping the langue list up to date. Two approaches:

  • Create a separate language list file under /StoreMetadata/screenshots, which we update with GH workflows (in the app repo or in this repo, depending on the criteria we decide on)
  • Let the script check an external/existing file or folder (again, depending on the criteria we decide on)

Then we also need to decide what our criterium is:

  • we release the app in that language, i.e. we can make localised screenshots (https://github.com/AntennaPod/AntennaPod/blob/develop/.tx/config)
  • we have the screenshot title strings in that language, i.e. we can make localised frames (/screenshots/strings/...)
  • both of the above: we have screenshot titles in that language and release the app in that language.

To have the widest possible set of screenshots, I would go for the first option.

@ByteHamster Would you agree with me on the criteria for 01_takeScreenshots.sh? And for the approach, do you have a preference?

When we have a decision on both points I'd be happy to start tinkering and prepare a PR.


Also for the final play store images, the list of languages is defined manually:

We'll want to automate that language list one as well, and need a similar decision on criteria. For me, having a localised play store image title with an English screenshot gives a bit of an odd signal to the user: we want to promote in your language but we don't care enough to translate the actual app. So this I would avoid.

So here we should, I think, consider a combination of both criteria.

@ByteHamster
Copy link
Member

It'd be better to automate that, so we don't have to think about keeping the langue list up to date

I would prefer the second variant, eg checking the list of languages we already support. No need to do a workflow.

Then we also need to decide what our criterium is

I would prefer the second option because the screenshots are rather small compared to the heading. If the heading is not translated, users will probably not look at the screenshots in detail anyway. An additional advantage is that the language format of the screenshots is different from the language format of the app supported languages. The format from the screenshot titles is the one we need here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants